Skip to content

Remove redundant default substeps options#786

Merged
MakisH merged 2 commits into
developfrom
default-substeps
May 19, 2026
Merged

Remove redundant default substeps options#786
MakisH merged 2 commits into
developfrom
default-substeps

Conversation

@MakisH
Copy link
Copy Markdown
Member

@MakisH MakisH commented May 17, 2026

This PR removes the now redundant default substeps="true" option from all tutorial cases where this was defined. Closes #377.

Related to #281, #388, #498, and #597 and

@uekerman any reason to still keep these explicit?

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.

@MakisH MakisH self-assigned this May 17, 2026
Copy link
Copy Markdown
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should indeed be a "nop" as it is the default now.
Do we have any substeps="false" in the tutorials? If yes, we could also think about removing these, but there, we should have a closer look.

@MakisH
Copy link
Copy Markdown
Member Author

MakisH commented May 19, 2026

This should indeed be a "nop" as it is the default now. Do we have any substeps="false" in the tutorials? If yes, we could also think about removing these, but there, we should have a closer look.

No, the only instances of substeps are in these tutorials, with now default values.

@MakisH MakisH merged commit be7a576 into develop May 19, 2026
1 check passed
@MakisH MakisH deleted the default-substeps branch May 19, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove substeps="false" option when it becomes supported

2 participants